Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations table is saved with extension #2239

Closed
woltob opened this issue Sep 28, 2021 · 3 comments
Closed

Migrations table is saved with extension #2239

woltob opened this issue Sep 28, 2021 · 3 comments
Labels
breaking change enhancement New feature or request
Milestone

Comments

@woltob
Copy link

woltob commented Sep 28, 2021

Migrations table is saving the extension of the migration file as well.
This causes issues for me since I am using npx mikro-orm migration:up to run the migrations locally, but have to rely on JS compiled migrations on deployment and are running migrations inside the application code (main.ts) on application start up.

Can you add a fix please that would omit the extension (js or ts) or at least give the option so that this causing no issues.
Currently, it wants to run the migrations again as it does not recognise js migrations that already run.

image

@B4nan B4nan removed their assignment Sep 29, 2021
@B4nan
Copy link
Member

B4nan commented Sep 29, 2021

Would be nice if you stop assigning me. It feels quite rude from you - I am not your employee or a paid support, this is not how open source work.

Anyway, this is something I am planning to do in v5 - it will be a breaking change, so don't expect it in v4.

@B4nan B4nan added breaking change enhancement New feature or request labels Sep 29, 2021
@B4nan B4nan added this to the 5.0 milestone Sep 29, 2021
@woltob
Copy link
Author

woltob commented Sep 29, 2021

Hi B4nan,

thanks for the quick reply. I am not aware that I actively assigned you, that seems to happen automatically when I submit a bug. Also, in no way do I want to be rude or see you as support. It is just that we are under a lot of pressure and the previous lead engineer decided to go with MikroORM as it seems to be very stable.

Thank you very much for your work, very much appreciated!

@woltob woltob closed this as completed Sep 29, 2021
@B4nan
Copy link
Member

B4nan commented Sep 29, 2021

Ooops my bad, I remembered I removed myself from automatic assignees but I just removed the automatic bug tagging - so sorry for the rant, my bad!

And let's keep this open, as said, I do plan to work on this in v5, this is definitely someting to improve.

@B4nan B4nan reopened this Sep 29, 2021
@B4nan B4nan closed this as completed in 4036716 Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants