feat(core): add support for multiple schemas (including UoW) #2296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2296 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 186 186
Lines 10311 10366 +55
Branches 2255 2274 +19
=========================================
+ Hits 10311 10366 +55
Continue to review full report at Codecov.
|
Closes #2074 BREAKING CHANGE: `em.getReference()` now has options parameter.
…(WIP) Support for working with `SchemaGenerator` with specific schema. Entities can now specify `schema: '*'`, that way they will be ignored in schema generator unless `schema` option is specified. - if we have schema specified on entity level, it only exists in that schema - if we have * schema on entity, it can exist in any schema, always controlled by the parameter - no schema on entity - default schema or from global orm config
This was referenced Nov 7, 2021
|
Thanks a lot for this feature! |
Should this breaking change also be described in the |
|
Oh yes, I must have missed that, sorry. Good job! |
B4nan
pushed a commit
that referenced
this pull request
Sep 25, 2023
Hi, I want to start with thanking you all for this great ORM that is so actively maintained and offer so many great features. One thing that really catches my eye is the per request (shell)EntityManager that I think will make this ORM a winner when it comes to multi tenancy. Almost all of the other big ORM libraries are based on a global concept. My aim with this PR is to make a shoot at implementing schema based multi tenancy support with help of the per request EntityManager. With this PR it's possible to set a schema when forking the EntityManager. That schema will be applied as a default schema if no other schema is present. It makes use of the schema options introduced in: #2296
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entity instances now hold schema name (as part of
WrappedEntity). Managed entities will have the schema fromFindOptionsor metadata. Methods that create new entity instances likeem.create()orem.getReference()now have an options parameter to allow setting the schema. We can also usewrap(entity).setSchema().Entities can now specify
@Entity({ schema: '*' }), that way they will be ignored inSchemaGeneratorunlessschemaoption is specified.Closes #2074
BREAKING CHANGE:
em.getReference()now has options parameter.