-
-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): implement auto-flush mode #2491
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2491 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 190 190
Lines 10874 10958 +84
Branches 2489 2502 +13
=========================================
+ Hits 10874 10958 +84
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks state before querying entities and flush automatically if we have queued changes to entities that are being queried.
The flushing strategy is given by the
flushMode
of the current runningEntityManager
.FlushMode.COMMIT
- TheEntityManager
tries to delay the flush until the current Transaction is committed, although it might flush prematurely too.FlushMode.AUTO
- This is the default mode, and it flushes theEntityManager
only if necessary.FlushMode.ALWAYS
- Flushes theEntityManager
before every query.FlushMode.AUTO
will try to detect changes on the entity we are querying, and flushif there is an overlap:
We can set the flush mode on different places:
Options.flushMode
EntityManager
instance (and its forks) viaem.setFlushMode()
EntityManager
fork viaem.fork({ flushMode })
qb.setFlushMode()
em.transactional(..., { flushMode })
Based on https://docs.jboss.org/hibernate/orm/5.1/userguide/html_single/chapters/flushing/Flushing.html
Closes #2359