fix(core): fix nested query with fk as pk

[ml1nk]

Some tests are broken but at least the cases of #2649 are working as expected. Both changes break tests separately and i only have a rough idea why.

@B4nan I try to improve this fix tomorrow, but i'm missing insight.

[B4nan]

let's not amend/force push after you get a review. this makes reviewing the changes almost impossible to me, as I only see the whole commit and not the changes you did after i reviewed it

[ml1nk]

let's not amend/force push after you get a review. this makes reviewing the changes almost impossible to me, as I only see the whole commit and not the changes you did after i reviewed it

I will stop amending, sorry for creating more work for you.

Any idea how to decrease the complexity to solve the codeclimate issue?

[B4nan]

Any idea how to decrease the complexity to solve the codeclimate issue?

You could move some of the logic to new method to distribute the complexity.

But dont be too concerned with codeclimate, as long as we will have 100% branch coverage I will be happy to merge. (note that we dont have it, one line is not covered by tests currently)

[B4nan]

Thanks a lot!