New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Flexible connection resolution strategy when using read-replicas #2896
feat(core): Flexible connection resolution strategy when using read-replicas #2896
Conversation
please remove all unrelated code style changes, and the yarn log file |
Note that we need to keep supporting the string constants (otherwise this would be a breaking change on type level), so remove all of those changes too. |
f01eb0e
to
a179406
Compare
I restored the string constants but did wrap them to a union-type so as to make signatures shorter & 'safer' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, just two nits
Codecov Report
@@ Coverage Diff @@
## master #2896 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 194 194
Lines 11738 11756 +18
Branches 2701 2703 +2
=========================================
+ Hits 11738 11756 +18
Continue to review full report at Codecov.
|
Allows developers working with read-replicas the flexibility to:
FindOptions
andCountOptions
with aconnectionType
property