fix(mongo): retry only 3 times if ensuring indexes fails

[jagzmz]

Closes #3261

@B4nan I am not sure how would I reproduce the error on tests, they are not complete as of now, any suggestions ?

[codecov-commenter]

Codecov Report

Merging #3272 (20722a2) into master (972e5ba) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #3272   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          194       194           
  Lines        12094     12097    +3     
  Branches      2806      2807    +1     
=========================================
+ Hits         12094     12097    +3     

Impacted Files	Coverage Δ
packages/mongodb/src/MongoSchemaGenerator.ts	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 972e5ba...20722a2. Read the comment docs.

[B4nan]

Here it should be enough if you define the unique constraint, but dont create it right ahead, create the two rows, and then call ensureIndexes() afterwards. First comment out the changes you made to verify such test will fail, then see how your fix is working.

Note that to have that test "work" on every run, you will also need to wipe the collections so the indexes also get wiped.

[B4nan]

thanks! just few nits before we merge

[B4nan]

actually, lets not introduce another parameter, we already have the options there, so lets just add the retryLimit inside that

Suggested change

	async ensureIndexes(options: EnsureIndexesOptions = {}, retryLimit = 3): Promise<void> {
	async ensureIndexes(options: EnsureIndexesOptions = {}): Promise<void> {
	options.retryLimit ??= 3

[jagzmz]

Updated!

[B4nan]

Suggested change

	if (retryLimit === 1) {
	const failedIndexes = res.filter(r => r.status === 'rejected').map((r: Dictionary, id) => `${promises[id][0]} - ${r.reason}`);
	throw new Error(`Failed to create indexes: ${failedIndexes.join(', ')}`);
	}
	await this.ensureIndexes({ retry: collectionsWithFailedIndexes }, retryLimit - 1);
	if (options.retryLimit === 1) {
	const failedIndexes = res.filter(r => r.status === 'rejected').map((r: Dictionary, id) => `${promises[id][0]} - ${r.reason}`);
	throw new Error(`Failed to create indexes: ${failedIndexes.join(', ')}`);
	}
	await this.ensureIndexes({
	retry: collectionsWithFailedIndexes,
	retryLimit: retryLimit - 1,
	});

[jagzmz]

Updated

[B4nan]

Thanks!