Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(knex): fix $or over 1:m and m:1 auto-joined relations #3307

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

diffcunha
Copy link
Contributor

Fixes #3301

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2022

Codecov Report

Merging #3307 (20595bb) into master (f0bc261) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #3307   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          194       194           
  Lines        12136     12145    +9     
  Branches      2818      2822    +4     
=========================================
+ Hits         12136     12145    +9     
Impacted Files Coverage Δ
packages/knex/src/query/ObjectCriteriaNode.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0bc261...20595bb. Read the comment docs.

Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@B4nan B4nan merged commit b6f12b2 into mikro-orm:master Jul 18, 2022
@diffcunha
Copy link
Contributor Author

No problem @B4nan, Mikro is great! We should work on Polymorphic Relationships :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InvalidFieldNameException when using $eq inside $or over referenced entity field
3 participants