Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): compile with module: 'Node16' to have real dynamic imports #3439

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

B4nan
Copy link
Member

@B4nan B4nan commented Aug 31, 2022

This should still preserve compatibility with node 14, we just get a dynamic import in the compiled version, instead of the hack with eval.

@B4nan B4nan marked this pull request as ready for review August 31, 2022 15:07
@B4nan B4nan merged commit 50347ef into master Aug 31, 2022
@B4nan B4nan deleted the node16 branch August 31, 2022 15:07
@biancazzurri
Copy link
Contributor

Hey! I think that something is not compatible with Node14 because when I use the cli and the config loads 'async_hooks', like this:
import { AsyncLocalStorage } from 'async_hooks';
it gives error:
Module '"async_hooks"' has no exported member 'AsyncLocalStorage'

@B4nan B4nan restored the node16 branch January 10, 2023 19:11
@B4nan B4nan deleted the node16 branch January 10, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants