Creating a Postgres database fails since 5.5.3

[briandiephuis]

Describe the bug
Creating a Postgres database fails since 5.5.3. Since this change our tests no longer run. In our integration tests we create a new database for just those tests, unfortunately automatically creating the database no longer works.

If we revert this method (manually in node_modules/@mikro-orm/postgresql/PostgreSqlSchemaHelper.js), everything works as expected:

  getManagementDbName(): string {
    return undefined; // instead of ''
  }

Not sure why though 🤔

Stack trace

DriverException: database "{ database username }" does not exist

*note that it logs the database username instead of the dbName 🤷

To Reproduce
Steps to reproduce the behavior:

1. Set config to a non-existing dbName
2. Start app
3. Unable to create dbName

Expected behavior
Mikro-ORM should correctly create the desired database and connect to it.

Additional context
Connecting to an existing database works just fine.

Versions

Dependency	Version
node	18.12.1
typescript	4.8.4
mikro-orm	5.5.3
@mikro-orm/postgresql	5.5.3

[B4nan]

I've been fixing this 3 times already, I can't help without a complete reproduction, as I would almost certainly break something else (not to mention I have no idea how I would reproduce this).

Closing before you provide one.

[B4nan]

Start with providing complete ORM config - and I really mean complete, no blank spaces and variables, I need all the actual values (mangled of course, I dont care about your user/pass/host, but I need to see exact values that reproduce this).

[B4nan]

Also, are you using env vars? Client URL (connection string)? Any special characters (namely :) in your username/password?

[briandiephuis]

Ok, thanks for the quick reply! I'll provide more info soon.

[briandiephuis]

@B4nan I've created this repo with a minimal setup -that represents what we use as much without too much bloat- to reproduce the bug. Let me know if this is too much or if you need anything else! The readme shows how to reproduce it in 5.5.2 and 5.5.3.

https://github.com/briandiephuis/nestjs-mikro-orm-example

[briandiephuis]

+any feedback on our test-setup is much appreciated ;)

[B4nan]

Hmmm looks like postgres requires the database name, and defaults to the user name when it is not present. Will need to revert the changes and allow overriding the management db name for those who dont have the postgres database.