Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): re-export the core package from all drivers #3816

Merged
merged 1 commit into from
Dec 3, 2022
Merged

Conversation

B4nan
Copy link
Member

@B4nan B4nan commented Dec 3, 2022

Every driver now reexport the whole @mikro-orm/core package. This means we no longer have to think about what package to use for imports, the driver package should be always preferred.

-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';

Every driver now reexport the whole `@mikro-orm/core` package. This means
we no longer have to think about what package to use for imports, the driver
package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2022

Codecov Report

Base: 99.93% // Head: 99.93% // No change to project coverage 👍

Coverage data is based on head (7d7bce0) compared to base (124ecad).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##               v6    #3816   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files         216      216           
  Lines       13426    13426           
  Branches     3127     3127           
=======================================
  Hits        13417    13417           
  Misses          9        9           
Impacted Files Coverage Δ
packages/mariadb/src/MariaDbSchemaHelper.ts 100.00% <ø> (ø)
...ckages/cli/src/commands/MigrationCommandFactory.ts 100.00% <100.00%> (ø)
packages/knex/src/schema/DatabaseTable.ts 100.00% <100.00%> (ø)
packages/knex/src/schema/SchemaComparator.ts 100.00% <100.00%> (ø)
packages/knex/src/schema/SchemaHelper.ts 100.00% <100.00%> (ø)
packages/knex/src/schema/SqlSchemaGenerator.ts 100.00% <100.00%> (ø)
packages/mysql/src/MySqlSchemaHelper.ts 100.00% <100.00%> (ø)
packages/postgresql/src/PostgreSqlSchemaHelper.ts 100.00% <100.00%> (ø)
packages/sqlite/src/SqliteSchemaHelper.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@B4nan B4nan merged commit a764b7d into v6 Dec 3, 2022
@B4nan B4nan deleted the reexport-core branch December 3, 2022 15:12
B4nan added a commit that referenced this pull request Dec 3, 2022
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Dec 5, 2022
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Dec 6, 2022
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Dec 8, 2022
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Dec 12, 2022
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Dec 18, 2022
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Dec 27, 2022
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Jan 2, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Jan 4, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Jan 8, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
@B4nan B4nan restored the reexport-core branch January 10, 2023 19:12
@B4nan B4nan deleted the reexport-core branch January 10, 2023 19:17
B4nan added a commit that referenced this pull request Jan 13, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Jan 26, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Feb 5, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Feb 12, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Feb 17, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Feb 17, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Feb 26, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Mar 19, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Apr 6, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Apr 10, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Apr 12, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Apr 26, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request May 14, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request May 14, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request May 24, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request May 26, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Jun 11, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Sep 10, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Sep 20, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Sep 24, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Sep 30, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
@B4nan B4nan mentioned this pull request Sep 30, 2023
22 tasks
B4nan added a commit that referenced this pull request Oct 2, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Oct 17, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Oct 21, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Oct 25, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Nov 2, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
B4nan added a commit that referenced this pull request Nov 5, 2023
Every driver now reexport the whole `@mikro-orm/core` package. This
means we no longer have to think about what package to use for imports,
the driver package should be always preferred.

```diff
-import { Entity, PrimaryKey } from '@mikro-orm/core';
-import { MikroORM, EntityManager } from '@mikro-orm/mysql';
+import { Entity, PrimaryKey, MikroORM, EntityManager } from '@mikro-orm/mysql';
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants