Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect postgresql no timestamptz precision default #3832

Merged
merged 2 commits into from Dec 8, 2022

Conversation

yeedle
Copy link
Contributor

@yeedle yeedle commented Dec 6, 2022

See details in #3824. This PR removes the default fallback to a precision of 0 so that for postgresql the correct type for Date (timestamptz with no precision) is generated, and it adds the fallback to 0 downstream in platform-specific contexts.
(this PR is a duplicate of #3826, reopened against the v6 branch)

@B4nan B4nan merged commit 74705a3 into mikro-orm:v6 Dec 8, 2022
@B4nan
Copy link
Member

B4nan commented Dec 8, 2022

thanks!

B4nan pushed a commit that referenced this pull request Dec 8, 2022
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Dec 12, 2022
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Dec 18, 2022
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Dec 27, 2022
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Jan 2, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Jan 4, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Jan 8, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Jan 13, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Jan 26, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Feb 5, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Feb 12, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Feb 17, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Feb 17, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Feb 26, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Mar 19, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Apr 6, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
@B4nan B4nan mentioned this pull request Apr 7, 2023
B4nan pushed a commit that referenced this pull request Apr 10, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Apr 12, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Apr 26, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request May 14, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request May 14, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request May 24, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request May 26, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Jun 11, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Sep 10, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Sep 20, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Sep 24, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Sep 30, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Oct 2, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Oct 17, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Oct 21, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Oct 25, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Nov 2, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
B4nan pushed a commit that referenced this pull request Nov 5, 2023
See details in #3824. This
PR removes the default fallback to a precision of 0 so that for
postgresql the correct type for Date (timestamptz with no precision) is
generated, and it adds the fallback to 0 downstream in platform-specific
contexts.
(this PR is a duplicate of
#3826, reopened against the
`v6` branch)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants