Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(migrations): add cjs option for emit #4016

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

erie0210
Copy link
Contributor

@erie0210 erie0210 commented Feb 6, 2023

In case @stabai doesn't reply, I'd like to submit my PR.

Closes #4005

Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Let's adjust the default glob too, so it respects cjs files automatically, otherwise looking good.

@B4nan
Copy link
Member

B4nan commented Feb 6, 2023

and actually another one - do the same for the migrations-mongodb package, the code is unfortunately duplicated (otherwise we would have to have some internal packages, had it this way before and it was causing another sort of issues)

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Base: 99.77% // Head: 99.77% // No change to project coverage 👍

Coverage data is based on head (da5418b) compared to base (31b89b8).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4016   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files         214      214           
  Lines       13736    13736           
  Branches     3216     3216           
=======================================
  Hits        13705    13705           
  Misses         29       29           
  Partials        2        2           
Impacted Files Coverage Δ
packages/core/src/utils/Configuration.ts 100.00% <ø> (ø)
packages/migrations-mongodb/src/Migrator.ts 97.75% <ø> (ø)
packages/migrations/src/Migrator.ts 97.89% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@B4nan B4nan changed the title feat(migration): add cjs option for emit feat(migrations): add cjs option for emit Feb 7, 2023
@B4nan B4nan merged commit d5cfa22 into mikro-orm:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to emit js migrations with .cjs extension
3 participants