feat(core): deprecate persist/flush/remove methods from EntityRepository
#4259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sitory` Both persist and flush are tied to the EM instance, we have the repository shortcuts, but they feel confusing, as they might give users false sense that they do something only with that given entity type. Maybe we should remove them and make the em getter public instead, to preserve easy access to the functionality. In preparation for removal of those methods in v6, all the following `EntityRepository` methods are now deprecated: - persist - persistAndFlush - remove - removeAndFlush - flush Additionally, there is a new public `repo.getEntityManager()` method available. Related: #3989
B4nan
changed the title
persist/flush/remove methods from `EntityRepo…persist/flush/remove methods from EntityRepository
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4259 +/- ##
==========================================
- Coverage 99.70% 99.65% -0.05%
==========================================
Files 214 214
Lines 14026 14032 +6
Branches 3296 3296
==========================================
Hits 13984 13984
- Misses 41 47 +6
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
jsprw
pushed a commit
to jsprw/mikro-orm-full-text-operators
that referenced
this pull request
May 7, 2023
…sitory` (mikro-orm#4259) Both persist and flush are tied to the EM instance, we have the repository shortcuts, but they feel confusing, as they might give users false sense that they do something only with that given entity type. Maybe we should remove them and make the em getter public instead, to preserve easy access to the functionality. In preparation for removal of those methods in v6, all the following `EntityRepository` methods are now deprecated: - persist - persistAndFlush - remove - removeAndFlush - flush Additionally, there is a new public `repo.getEntityManager()` method available. Related: mikro-orm#3989
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both persist and flush are tied to the EM instance, we have the repository shortcuts, but they feel confusing, as they might give users false sense that they do something only with that given entity type. Maybe we should remove them and make the em getter public instead, to preserve easy access to the functionality.
In preparation for removal of those methods in v6, all the following
EntityRepositorymethods are now deprecated:Additionally, there is a new public
repo.getEntityManager()method available.Related: #3989