Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): await the yargs.parse call in esm.ts #4272

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

DASPRiD
Copy link
Contributor

@DASPRiD DASPRiD commented Apr 25, 2023

Related to #4265

3757472 did fix the call in cli.ts but forgot to update esm.ts.

Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@B4nan B4nan merged commit dcdf70a into mikro-orm:master Apr 25, 2023
6 of 7 checks passed
@DASPRiD
Copy link
Contributor Author

DASPRiD commented Apr 25, 2023

That was fast, the CI couldn't even finish validating ;)

@B4nan
Copy link
Member

B4nan commented Apr 25, 2023

Well, the cli.ts and esm.ts are the only files that are not tested anyhow, so waiting for it isnt really worth it :D

@DASPRiD
Copy link
Contributor Author

DASPRiD commented Apr 25, 2023

Haha good point. Remind me to get you a beer next time I'm close to your city :D

jsprw pushed a commit to jsprw/mikro-orm-full-text-operators that referenced this pull request May 7, 2023
Related to mikro-orm#4265


mikro-orm@3757472
did fix the call in `cli.ts` but forgot to update `esm.ts`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants