Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): expose missing migration:check command #4388

Merged
merged 2 commits into from May 26, 2023

Conversation

stefansundin
Copy link
Contributor

Please let me know if you want me to make any changes. Feel free to make edits to the branch directly if you prefer that.

Comment on lines +83 to 84
args.option('n', {
alias: 'name',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's an alternative fix if you don't want a short option.

Suggested change
args.option('n', {
alias: 'name',
args.option('name', {

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f27ee9a) 99.60% compared to head (eb1f249) 99.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4388   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files         214      214           
  Lines       14176    14176           
  Branches     3353     3353           
=======================================
  Hits        14120    14120           
  Misses         55       55           
  Partials        1        1           
Impacted Files Coverage Δ
packages/cli/src/CLIConfigurator.ts 100.00% <ø> (ø)
...ckages/cli/src/commands/MigrationCommandFactory.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@B4nan B4nan changed the title fix(cli): fix migration:check fix(cli): expose missing migration:check command May 26, 2023
@B4nan B4nan merged commit 79e128e into mikro-orm:master May 26, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants