fix(core): refactor mapping of Date properties
#4391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v6 #4391 +/- ##
==========================================
- Coverage 99.53% 99.47% -0.07%
==========================================
Files 218 218
Lines 14723 14785 +62
Branches 3399 3411 +12
==========================================
+ Hits 14655 14707 +52
- Misses 67 76 +9
- Partials 1 2 +1
☔ View full report in Codecov by Sentry. |
Previously, mapping of datetime columns to JS `Date` objects was dependent on the driver, while SQLite didn't have this out of box support and required manual conversion on various places. All drivers now have disabled `Date` conversion and this is now handled explicitly, in the same way for all of them. Moreover, the `date` type was previously seen as a `datetime`, while now only `Date` (with uppercase `D`) will be considered as `datetime`, while `date` is just a `date`.
B4nan
added a commit
that referenced
this pull request
Jun 11, 2023
Previously, mapping of datetime columns to JS `Date` objects was dependent on the driver, while SQLite didn't have this out of box support and required manual conversion on various places. There were also places that didn't convert dates properly, e.g. inside embedded objects. All drivers now have disabled `Date` conversion and this is handled explicitly, in the same way for all the drivers. Moreover, the `date` type was previously seen as a `datetime`, while now only `Date` (with uppercase `D`) will be considered as `datetime`, while `date` is just a `date`. Closes #4362 Closes #4360 Closes #1476
B4nan
added a commit
that referenced
this pull request
Sep 10, 2023
Previously, mapping of datetime columns to JS `Date` objects was dependent on the driver, while SQLite didn't have this out of box support and required manual conversion on various places. There were also places that didn't convert dates properly, e.g. inside embedded objects. All drivers now have disabled `Date` conversion and this is handled explicitly, in the same way for all the drivers. Moreover, the `date` type was previously seen as a `datetime`, while now only `Date` (with uppercase `D`) will be considered as `datetime`, while `date` is just a `date`. Closes #4362 Closes #4360 Closes #1476
B4nan
added a commit
that referenced
this pull request
Sep 20, 2023
Previously, mapping of datetime columns to JS `Date` objects was dependent on the driver, while SQLite didn't have this out of box support and required manual conversion on various places. There were also places that didn't convert dates properly, e.g. inside embedded objects. All drivers now have disabled `Date` conversion and this is handled explicitly, in the same way for all the drivers. Moreover, the `date` type was previously seen as a `datetime`, while now only `Date` (with uppercase `D`) will be considered as `datetime`, while `date` is just a `date`. Closes #4362 Closes #4360 Closes #1476
B4nan
added a commit
that referenced
this pull request
Sep 24, 2023
Previously, mapping of datetime columns to JS `Date` objects was dependent on the driver, while SQLite didn't have this out of box support and required manual conversion on various places. There were also places that didn't convert dates properly, e.g. inside embedded objects. All drivers now have disabled `Date` conversion and this is handled explicitly, in the same way for all the drivers. Moreover, the `date` type was previously seen as a `datetime`, while now only `Date` (with uppercase `D`) will be considered as `datetime`, while `date` is just a `date`. Closes #4362 Closes #4360 Closes #1476
B4nan
added a commit
that referenced
this pull request
Sep 30, 2023
Previously, mapping of datetime columns to JS `Date` objects was dependent on the driver, while SQLite didn't have this out of box support and required manual conversion on various places. There were also places that didn't convert dates properly, e.g. inside embedded objects. All drivers now have disabled `Date` conversion and this is handled explicitly, in the same way for all the drivers. Moreover, the `date` type was previously seen as a `datetime`, while now only `Date` (with uppercase `D`) will be considered as `datetime`, while `date` is just a `date`. Closes #4362 Closes #4360 Closes #1476
B4nan
added a commit
that referenced
this pull request
Oct 2, 2023
Previously, mapping of datetime columns to JS `Date` objects was dependent on the driver, while SQLite didn't have this out of box support and required manual conversion on various places. There were also places that didn't convert dates properly, e.g. inside embedded objects. All drivers now have disabled `Date` conversion and this is handled explicitly, in the same way for all the drivers. Moreover, the `date` type was previously seen as a `datetime`, while now only `Date` (with uppercase `D`) will be considered as `datetime`, while `date` is just a `date`. Closes #4362 Closes #4360 Closes #1476
B4nan
added a commit
that referenced
this pull request
Oct 17, 2023
Previously, mapping of datetime columns to JS `Date` objects was dependent on the driver, while SQLite didn't have this out of box support and required manual conversion on various places. There were also places that didn't convert dates properly, e.g. inside embedded objects. All drivers now have disabled `Date` conversion and this is handled explicitly, in the same way for all the drivers. Moreover, the `date` type was previously seen as a `datetime`, while now only `Date` (with uppercase `D`) will be considered as `datetime`, while `date` is just a `date`. Closes #4362 Closes #4360 Closes #1476
B4nan
added a commit
that referenced
this pull request
Oct 21, 2023
Previously, mapping of datetime columns to JS `Date` objects was dependent on the driver, while SQLite didn't have this out of box support and required manual conversion on various places. There were also places that didn't convert dates properly, e.g. inside embedded objects. All drivers now have disabled `Date` conversion and this is handled explicitly, in the same way for all the drivers. Moreover, the `date` type was previously seen as a `datetime`, while now only `Date` (with uppercase `D`) will be considered as `datetime`, while `date` is just a `date`. Closes #4362 Closes #4360 Closes #1476
B4nan
added a commit
that referenced
this pull request
Oct 25, 2023
Previously, mapping of datetime columns to JS `Date` objects was dependent on the driver, while SQLite didn't have this out of box support and required manual conversion on various places. There were also places that didn't convert dates properly, e.g. inside embedded objects. All drivers now have disabled `Date` conversion and this is handled explicitly, in the same way for all the drivers. Moreover, the `date` type was previously seen as a `datetime`, while now only `Date` (with uppercase `D`) will be considered as `datetime`, while `date` is just a `date`. Closes #4362 Closes #4360 Closes #1476
B4nan
added a commit
that referenced
this pull request
Nov 2, 2023
Previously, mapping of datetime columns to JS `Date` objects was dependent on the driver, while SQLite didn't have this out of box support and required manual conversion on various places. There were also places that didn't convert dates properly, e.g. inside embedded objects. All drivers now have disabled `Date` conversion and this is handled explicitly, in the same way for all the drivers. Moreover, the `date` type was previously seen as a `datetime`, while now only `Date` (with uppercase `D`) will be considered as `datetime`, while `date` is just a `date`. Closes #4362 Closes #4360 Closes #1476
B4nan
added a commit
that referenced
this pull request
Nov 5, 2023
Previously, mapping of datetime columns to JS `Date` objects was dependent on the driver, while SQLite didn't have this out of box support and required manual conversion on various places. There were also places that didn't convert dates properly, e.g. inside embedded objects. All drivers now have disabled `Date` conversion and this is handled explicitly, in the same way for all the drivers. Moreover, the `date` type was previously seen as a `datetime`, while now only `Date` (with uppercase `D`) will be considered as `datetime`, while `date` is just a `date`. Closes #4362 Closes #4360 Closes #1476
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, mapping of datetime columns to JS
Dateobjects was dependent on the driver, while SQLite didn't have this out of box support and required manual conversion on various places. There were also places that didn't convert dates properly, e.g. inside embedded objects. All drivers now have disabledDateconversion and this is handled explicitly, in the same way for all the drivers.Moreover, the
datetype was previously seen as adatetime, while now onlyDate(with uppercaseD) will be considered asdatetime, whiledateis just adate.Closes #4362
Closes #4360
Closes #1476