fix(core): fix returning clause for upsert with embeddables #4427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen upserting with embeddables
B4nan
reviewed
Jun 7, 2023
tests/features/upsert/upsert.test.ts
Outdated
| test('em.upsert(entity) with embeddable', async () => { | ||
| const testEntity = orm.em.create(FooBarWithEmbeddable, { fooBarEmbeddable: {} }); | ||
|
|
||
| const insertedEntity = await orm.em.upsert(FooBarWithEmbeddable, testEntity); |
There was a problem hiding this comment.
since you pass in entity instance you can just do upsert(testEntity), also testEntity === insertedEntity, the return value makes sense only with the POJO signature
There was a problem hiding this comment.
Fixed it, basically anything can be done here. It's just to test that the upsert and upsertMany queries run successfully (not throw an InvalidFieldNameException).
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4427 +/- ##
==========================================
+ Coverage 99.61% 99.64% +0.03%
==========================================
Files 214 214
Lines 14179 14179
Branches 3358 3358
==========================================
+ Hits 14124 14129 +5
+ Misses 54 49 -5
Partials 1 1
☔ View full report in Codecov by Sentry. |
B4nan
approved these changes
Jun 7, 2023
B4nan
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hen upserting with embeddables
Currently, when you run upsert on an entity with an embeddable, the name of the embeddable is included in the returning statement and causing
InvalidFieldNameException.The produced query without the change: