fix(core): rework Collection initialization to use em.populate()
#4571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This unifies the population mechanism for to-many relations by using the `em.populate()` internally. Previously, the `Collection.init` (and methods using it, e.g. `loadItems`) were using custom implementation, which in some cases resulting in different results as opposed to `em.populate()`. With this PR, the `init` method is also using `em.populate`, yielding the same results as if you would populate the relation. Closes #4464
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v6 #4571 +/- ##
==========================================
- Coverage 99.38% 99.38% -0.01%
==========================================
Files 219 219
Lines 14859 14845 -14
Branches 3440 3443 +3
==========================================
- Hits 14768 14754 -14
Misses 88 88
Partials 3 3
☔ View full report in Codecov by Sentry. |
|
@B4nan by chance, does this refactor fix a potential issue where calling |
|
Yes, this PR is part of 6.0.0-dev.89. Keep in mind that |
B4nan
added a commit
that referenced
this pull request
Sep 10, 2023
…4571) This unifies the population mechanism for to-many relations by using the `em.populate()` internally. Previously, the `Collection.init` (and methods using it, e.g. `loadItems`) were using custom implementation, which in some cases resulting in different results as opposed to `em.populate()`. With this PR, the `init` method is also using `em.populate`, yielding the same results as if you would populate the relation. Closes #4464
B4nan
added a commit
that referenced
this pull request
Sep 20, 2023
…4571) This unifies the population mechanism for to-many relations by using the `em.populate()` internally. Previously, the `Collection.init` (and methods using it, e.g. `loadItems`) were using custom implementation, which in some cases resulting in different results as opposed to `em.populate()`. With this PR, the `init` method is also using `em.populate`, yielding the same results as if you would populate the relation. Closes #4464
B4nan
added a commit
that referenced
this pull request
Sep 24, 2023
…4571) This unifies the population mechanism for to-many relations by using the `em.populate()` internally. Previously, the `Collection.init` (and methods using it, e.g. `loadItems`) were using custom implementation, which in some cases resulting in different results as opposed to `em.populate()`. With this PR, the `init` method is also using `em.populate`, yielding the same results as if you would populate the relation. Closes #4464
B4nan
added a commit
that referenced
this pull request
Sep 30, 2023
…4571) This unifies the population mechanism for to-many relations by using the `em.populate()` internally. Previously, the `Collection.init` (and methods using it, e.g. `loadItems`) were using custom implementation, which in some cases resulting in different results as opposed to `em.populate()`. With this PR, the `init` method is also using `em.populate`, yielding the same results as if you would populate the relation. Closes #4464
B4nan
added a commit
that referenced
this pull request
Oct 2, 2023
…4571) This unifies the population mechanism for to-many relations by using the `em.populate()` internally. Previously, the `Collection.init` (and methods using it, e.g. `loadItems`) were using custom implementation, which in some cases resulting in different results as opposed to `em.populate()`. With this PR, the `init` method is also using `em.populate`, yielding the same results as if you would populate the relation. Closes #4464
B4nan
added a commit
that referenced
this pull request
Oct 17, 2023
…4571) This unifies the population mechanism for to-many relations by using the `em.populate()` internally. Previously, the `Collection.init` (and methods using it, e.g. `loadItems`) were using custom implementation, which in some cases resulting in different results as opposed to `em.populate()`. With this PR, the `init` method is also using `em.populate`, yielding the same results as if you would populate the relation. Closes #4464
B4nan
added a commit
that referenced
this pull request
Oct 21, 2023
…4571) This unifies the population mechanism for to-many relations by using the `em.populate()` internally. Previously, the `Collection.init` (and methods using it, e.g. `loadItems`) were using custom implementation, which in some cases resulting in different results as opposed to `em.populate()`. With this PR, the `init` method is also using `em.populate`, yielding the same results as if you would populate the relation. Closes #4464
B4nan
added a commit
that referenced
this pull request
Oct 25, 2023
…4571) This unifies the population mechanism for to-many relations by using the `em.populate()` internally. Previously, the `Collection.init` (and methods using it, e.g. `loadItems`) were using custom implementation, which in some cases resulting in different results as opposed to `em.populate()`. With this PR, the `init` method is also using `em.populate`, yielding the same results as if you would populate the relation. Closes #4464
B4nan
added a commit
that referenced
this pull request
Nov 2, 2023
…4571) This unifies the population mechanism for to-many relations by using the `em.populate()` internally. Previously, the `Collection.init` (and methods using it, e.g. `loadItems`) were using custom implementation, which in some cases resulting in different results as opposed to `em.populate()`. With this PR, the `init` method is also using `em.populate`, yielding the same results as if you would populate the relation. Closes #4464
B4nan
added a commit
that referenced
this pull request
Nov 5, 2023
…4571) This unifies the population mechanism for to-many relations by using the `em.populate()` internally. Previously, the `Collection.init` (and methods using it, e.g. `loadItems`) were using custom implementation, which in some cases resulting in different results as opposed to `em.populate()`. With this PR, the `init` method is also using `em.populate`, yielding the same results as if you would populate the relation. Closes #4464
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unifies the population mechanism for to-many relations by using the
em.populate()internally.Previously, the
Collection.init(and methods using it, e.g.loadItems) were using custom implementation, which in some cases resulting in different results as opposed toem.populate(). With this PR, theinitmethod is also usingem.populate, yielding the same results as if you would populate the relation.Closes #4464