New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add Collection.slice()
method
#4608
Conversation
Co-authored-by: Martin Adámek <banan23@gmail.com>
Co-authored-by: Martin Adámek <banan23@gmail.com>
Co-authored-by: Martin Adámek <banan23@gmail.com>
Co-authored-by: Martin Adámek <banan23@gmail.com>
Co-authored-by: Martin Adámek <banan23@gmail.com>
Co-authored-by: Martin Adámek <banan23@gmail.com>
Co-authored-by: Martin Adámek <banan23@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4608 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 215 215
Lines 14247 14261 +14
Branches 3389 3393 +4
=======================================
+ Hits 14196 14210 +14
Misses 50 50
Partials 1 1
☔ View full report in Codecov by Sentry. |
I was thinking instead of adding some minor collection methods in next pr, I will add them in here itself. What do you say |
i'd say it should be separate PRs so it results in multiple items in the changelog and please pay more attention to the comments, you still havent addressed all the missing spaces and wrong indents |
I do have editorconfig extension setup and it should take care of the indentation afaik |
Co-authored-by: Martin Adámek <banan23@gmail.com>
Co-authored-by: Martin Adámek <banan23@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all right, last few style changes. sorry for not having the linter set up properly, I hate to waste time (yours as well as mine) discussing style changes like this.
thanks!
tests/features/composite-keys/custom-pivot-entity.sqlite.test.ts
Outdated
Show resolved
Hide resolved
No worries man. With codebase of this size, these are bound to happen. |
Collection.slice()
method
Btw about the collections test, should I just add tests for a specific driver under |
We don't have to test this on all the drivers, in-memory sqlite is enough. |
Adds support for
Collection.slice()