Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix query processing when PK is falsy #4713

Merged
merged 3 commits into from Sep 20, 2023

Conversation

Robert-Schirmer
Copy link
Contributor

Fix case of processWhere returning empty object when the where clause is an entity with an int pk of 0

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
packages/core/src/utils/QueryHelper.ts 100.00%

📢 Thoughts on this report? Let us know!.

@B4nan B4nan changed the title fix(core): fix QueryHelper.processWhere entity condition with pk of 0 fix(core): fix query processing when PK is falsy Sep 20, 2023
@B4nan B4nan merged commit 3624cb7 into mikro-orm:master Sep 20, 2023
12 of 13 checks passed
@B4nan
Copy link
Member

B4nan commented Sep 20, 2023

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants