fix(core): ensure propagation and change-tracking works with useDefineForClassFields
#4730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neForClassFields` Propagation on new entities you create via constructor are supported too, by modifying the entity class prototype, but this technique fails when `useDefineForClassFields` TypeScript compiler flag is enabled (which is true when targeting `ES2022` or higher). You can get around this by using `declare` keyword in your entity definition, or by creating entity instances via `em.create()`, which will ensure the propagation is enabled. Closes #4216
Codecov ReportPatch coverage is 📢 Thoughts on this report? Let us know!. |
B4nan
added a commit
that referenced
this pull request
Sep 24, 2023
…neForClassFields` (#4730) Propagation failed when `useDefineForClassFields` TypeScript compiler flag was enabled (which is true when targeting `ES2022` or higher). This PR ensures the propagation works regardless of the flag, by ensuring the getters are set up when registering entity as managed (and on few other places) via the new `EntityHelper.ensurePropagation()` method. Moreover, this PR also enables the `useDefineForClassFields` flag, and since v6 is targeting es2022, we get no transpilation for class properties thanks to this. Closes #4216
B4nan
added a commit
that referenced
this pull request
Sep 30, 2023
…neForClassFields` (#4730) Propagation failed when `useDefineForClassFields` TypeScript compiler flag was enabled (which is true when targeting `ES2022` or higher). This PR ensures the propagation works regardless of the flag, by ensuring the getters are set up when registering entity as managed (and on few other places) via the new `EntityHelper.ensurePropagation()` method. Moreover, this PR also enables the `useDefineForClassFields` flag, and since v6 is targeting es2022, we get no transpilation for class properties thanks to this. Closes #4216
B4nan
added a commit
that referenced
this pull request
Oct 2, 2023
…neForClassFields` (#4730) Propagation failed when `useDefineForClassFields` TypeScript compiler flag was enabled (which is true when targeting `ES2022` or higher). This PR ensures the propagation works regardless of the flag, by ensuring the getters are set up when registering entity as managed (and on few other places) via the new `EntityHelper.ensurePropagation()` method. Moreover, this PR also enables the `useDefineForClassFields` flag, and since v6 is targeting es2022, we get no transpilation for class properties thanks to this. Closes #4216
B4nan
added a commit
that referenced
this pull request
Oct 17, 2023
…neForClassFields` (#4730) Propagation failed when `useDefineForClassFields` TypeScript compiler flag was enabled (which is true when targeting `ES2022` or higher). This PR ensures the propagation works regardless of the flag, by ensuring the getters are set up when registering entity as managed (and on few other places) via the new `EntityHelper.ensurePropagation()` method. Moreover, this PR also enables the `useDefineForClassFields` flag, and since v6 is targeting es2022, we get no transpilation for class properties thanks to this. Closes #4216
B4nan
added a commit
that referenced
this pull request
Oct 21, 2023
…neForClassFields` (#4730) Propagation failed when `useDefineForClassFields` TypeScript compiler flag was enabled (which is true when targeting `ES2022` or higher). This PR ensures the propagation works regardless of the flag, by ensuring the getters are set up when registering entity as managed (and on few other places) via the new `EntityHelper.ensurePropagation()` method. Moreover, this PR also enables the `useDefineForClassFields` flag, and since v6 is targeting es2022, we get no transpilation for class properties thanks to this. Closes #4216
B4nan
added a commit
that referenced
this pull request
Oct 25, 2023
…neForClassFields` (#4730) Propagation failed when `useDefineForClassFields` TypeScript compiler flag was enabled (which is true when targeting `ES2022` or higher). This PR ensures the propagation works regardless of the flag, by ensuring the getters are set up when registering entity as managed (and on few other places) via the new `EntityHelper.ensurePropagation()` method. Moreover, this PR also enables the `useDefineForClassFields` flag, and since v6 is targeting es2022, we get no transpilation for class properties thanks to this. Closes #4216
B4nan
added a commit
that referenced
this pull request
Nov 2, 2023
…neForClassFields` (#4730) Propagation failed when `useDefineForClassFields` TypeScript compiler flag was enabled (which is true when targeting `ES2022` or higher). This PR ensures the propagation works regardless of the flag, by ensuring the getters are set up when registering entity as managed (and on few other places) via the new `EntityHelper.ensurePropagation()` method. Moreover, this PR also enables the `useDefineForClassFields` flag, and since v6 is targeting es2022, we get no transpilation for class properties thanks to this. Closes #4216
B4nan
added a commit
that referenced
this pull request
Nov 5, 2023
…neForClassFields` (#4730) Propagation failed when `useDefineForClassFields` TypeScript compiler flag was enabled (which is true when targeting `ES2022` or higher). This PR ensures the propagation works regardless of the flag, by ensuring the getters are set up when registering entity as managed (and on few other places) via the new `EntityHelper.ensurePropagation()` method. Moreover, this PR also enables the `useDefineForClassFields` flag, and since v6 is targeting es2022, we get no transpilation for class properties thanks to this. Closes #4216
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagation failed when
useDefineForClassFieldsTypeScript compiler flag was enabled (which is true when targetingES2022or higher).This PR ensures the propagation works regardless of the flag, by ensuring the getters are set up when registering entity as managed (and on few other places) via the new
EntityHelper.ensurePropagation()method.Moreover, this PR also enables the
useDefineForClassFieldsflag, and since v6 is targeting es2022, we get no transpilation for class properties thanks to this.Closes #4216