feat(core): create context from async orm instance #4812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed mikro-orm#4805 Added support to orm instance which wraps inside of Promise to `@CreateRequestContext()` decorator. It now additionally supports `async` callback like the below ```ts async getOrm(): Promise<MikroORM>{ // } const ORM = getOrm(); @CreateRequestContext(async () => ORM) ``` Or Promise instance ```ts @CreateRequestContext(ORM) ``` Or async `orm` property ```ts class H { constructor(protected orm: Promise<MikroORM>) {} @CreateRequestContext() async handle() { } } ``` Let me know if you have any questions about this PR or need anything changed.
B4nan
requested changes
Oct 11, 2023
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
|
Updated the code as per your suggestion |
B4nan
reviewed
Oct 13, 2023
| @@ -86,6 +98,17 @@ class TestClass2 { | |||
|
|
|||
| } | |||
|
|
|||
| class TestClass3 { | |||
|
|
|||
| constructor(private readonly orm: Promise<MikroORM>) {} | |||
There was a problem hiding this comment.
this is really weird thing to support, a bad practice in general
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #4805
Added support to orm instance which wraps inside of Promise to
@CreateRequestContext()decorator.It now additionally supports
asynccallback like the belowOr Promise instance
Or async
ormpropertyLet me know if you have any questions about this PR or need anything changed.