feat(core): respect naming strategy and explicit field names on embedded properties #4866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B4nan
force-pushed
the
embedded-field-names
branch
from
3377ff0
to
71a70bd
Compare
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
…ded properties
This is breaking mainly for SQL drivers, where the default naming strategy is underscoring, and will now applied to the embedded properties too. You can restore to the old behaviour by implementing custom naming strategy, overriding the `propertyToColumnName` method. It now has a second boolean parameter to indicate if the property is defined inside a JSON object context.
```ts
import { UnderscoreNamingStrategy } from '@mikro-orm/core';
class CustomNamingStrategy extends UnderscoreNamingStrategy {
propertyToColumnName(propertyName: string, object?: boolean): string {
if (object) {
return propertyName;
}
return super.propertyToColumnName(propertyName, object);
}
}
```
Closes #4371
Closes #2165
Closes #2361
B4nan
force-pushed
the
embedded-field-names
branch
from
71a70bd
to
fff0469
Compare
This was referenced Oct 23, 2023
Closed
B4nan
added a commit
that referenced
this pull request
Oct 25, 2023
…ded properties (#4866) This is breaking mainly for SQL drivers, where the default naming strategy is underscoring, and will now applied to the embedded properties too. You can restore to the old behaviour by implementing custom naming strategy, overriding the `propertyToColumnName` method. It now has a second boolean parameter to indicate if the property is defined inside a JSON object context. ```ts import { UnderscoreNamingStrategy } from '@mikro-orm/core'; class CustomNamingStrategy extends UnderscoreNamingStrategy { propertyToColumnName(propertyName: string, object?: boolean): string { if (object) { return propertyName; } return super.propertyToColumnName(propertyName, object); } } ``` Closes #4371 Closes #2165 Closes #2361
B4nan
added a commit
that referenced
this pull request
Nov 2, 2023
…ded properties (#4866) This is breaking mainly for SQL drivers, where the default naming strategy is underscoring, and will now applied to the embedded properties too. You can restore to the old behaviour by implementing custom naming strategy, overriding the `propertyToColumnName` method. It now has a second boolean parameter to indicate if the property is defined inside a JSON object context. ```ts import { UnderscoreNamingStrategy } from '@mikro-orm/core'; class CustomNamingStrategy extends UnderscoreNamingStrategy { propertyToColumnName(propertyName: string, object?: boolean): string { if (object) { return propertyName; } return super.propertyToColumnName(propertyName, object); } } ``` Closes #4371 Closes #2165 Closes #2361
B4nan
added a commit
that referenced
this pull request
Nov 5, 2023
…ded properties (#4866) This is breaking mainly for SQL drivers, where the default naming strategy is underscoring, and will now applied to the embedded properties too. You can restore to the old behaviour by implementing custom naming strategy, overriding the `propertyToColumnName` method. It now has a second boolean parameter to indicate if the property is defined inside a JSON object context. ```ts import { UnderscoreNamingStrategy } from '@mikro-orm/core'; class CustomNamingStrategy extends UnderscoreNamingStrategy { propertyToColumnName(propertyName: string, object?: boolean): string { if (object) { return propertyName; } return super.propertyToColumnName(propertyName, object); } } ``` Closes #4371 Closes #2165 Closes #2361
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is breaking mainly for SQL drivers, where the default naming strategy is underscoring, and will now applied to the embedded properties too. You can restore to the old behaviour by implementing custom naming strategy, overriding the
propertyToColumnNamemethod. It now has a second boolean parameter to indicate if the property is defined inside a JSON object context.Closes #4371
Closes #2165
Closes #2361