feat(sql): use joined strategy as default for SQL drivers #4958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B4nan
force-pushed
the
joined-strategy-default
branch
from
3a0ba49
to
f3d3bcc
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4958 +/- ##
=======================================
Coverage 99.48% 99.48%
=======================================
Files 222 222
Lines 16156 16179 +23
Branches 3884 3893 +9
=======================================
+ Hits 16073 16096 +23
Misses 82 82
Partials 1 1 ☔ View full report in Codecov by Sentry. |
B4nan
force-pushed
the
joined-strategy-default
branch
from
f3d3bcc
to
cb67ddd
Compare
This builds on the foundation of #4957, which resolved the biggest difference of the strategies. As part of the switch, few other smaller bugs were also fixed, as most of the test suite is now using the joined strategy too, so it uncovered some bugs that were fixed only with the select-in. To keep the old behaviour, you can override the default loading strategy in your ORM config.
B4nan
force-pushed
the
joined-strategy-default
branch
from
cb67ddd
to
90d090d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the foundation of #4957, which resolved the biggest difference of the strategies. As part of the switch, few other smaller bugs were also fixed, as most of the test suite is now using the joined strategy too, so it uncovered some bugs that were fixed only with the select-in.
To keep the old behaviour, you can override the default loading strategy in your ORM config.