feat(core): allow setting logger context on EM level #5023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B4nan
force-pushed
the
em-logger-context
branch
from
10b6b4e
to
12094f0
Compare
The logger context can now be also set on `EntityManager` level, e.g. via `em.fork()`:
```ts
const fork = em.fork({
loggerContext: { meaningOfLife: 42 },
});
const res = await fork.findAll(Author);
```
Closes #5022
B4nan
force-pushed
the
em-logger-context
branch
from
12094f0
to
3c67855
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5023 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 221 221
Lines 16236 16248 +12
Branches 3901 3902 +1
=======================================
+ Hits 16185 16197 +12
Misses 51 51 ☔ View full report in Codecov by Sentry. |
The logger context can now be also set on `EntityManager` level, e.g. via `em.fork()`:
```ts
const fork = em.fork({
loggerContext: { meaningOfLife: 42 },
});
const res = await fork.findAll(Author);
```
Closes #5022
|
🤩 |
|
When's this expected to be release? |
|
Its part of v6, every commit is published to npm as a dev version, so you can try this out already. Will ship new rc version during today and stable maybe within few days. |
|
Amazing, thank you
…On Sat, 16 Dec 2023, 8:04 pm Martin Adámek, ***@***.***> wrote:
Its part of v6, every commit is published to npm as a dev version, so you
can try this out already. Will ship new rc version during today and stable
maybe within few days.
—
Reply to this email directly, view it on GitHub
<#5023 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEMBZHF2NVO7FCF6W3G2XDYJVPZPAVCNFSM6AAAAABAW5VCX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJYG43DONRQGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logger context can now be also set on
EntityManagerlevel, e.g. viaem.fork():Closes #5022