Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add support for Node.js 14 #522

Merged
merged 2 commits into from Apr 29, 2020
Merged

feat(core): add support for Node.js 14 #522

merged 2 commits into from Apr 29, 2020

Conversation

Yaty
Copy link
Contributor

@Yaty Yaty commented Apr 28, 2020

here we go again :)

@B4nan
Copy link
Member

B4nan commented Apr 28, 2020

Should be caused by node-postgres, it is supposed to be fixed in the latest patch version, can you try to upgrade it?

brianc/node-postgres#2180

@B4nan
Copy link
Member

B4nan commented Apr 28, 2020

You will need to update the lock file too I guess (by actually installing it via yarn)

@B4nan
Copy link
Member

B4nan commented Apr 28, 2020

Already did the update in dev branch, so its enough to rebase this now.

@B4nan
Copy link
Member

B4nan commented Apr 28, 2020

apparently there is one more issue with FileCacheAdapter:

FAIL tests/FileCacheAdapter.test.ts
  ● FileCacheAdapter › should ignore old cache

    TypeError: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received type number (123)TypeError [ERR_INVALID_ARG_TYPE]: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received type number (123)

       8 |     const origin = TEMP_DIR + '/.origin';
       9 |     const cache = new FileCacheAdapter({ cacheDir: TEMP_DIR }, TEMP_DIR);
    > 10 |     writeFileSync(origin, 123);
         |     ^
      11 |     await cache.set('cache-test-handle-1', 123, origin);
      12 |     await expect(cache.get('cache-test-handle-1')).resolves.toBe(123);
      13 | 

      at Object.<anonymous> (tests/FileCacheAdapter.test.ts:10:5)

Looks like its actually problem just with the test itself. Changing it to writeFileSync(origin, '123'); should fix it.

@Yaty
Copy link
Contributor Author

Yaty commented Apr 28, 2020

alright it seems ok now, thanks for guidance :)

@B4nan
Copy link
Member

B4nan commented Apr 29, 2020

Good, thank you! Let's make this feature commit so it gets to the changelog :]

@B4nan B4nan changed the title build: add Node.js 14 feat(core): add support for Node.js 14 Apr 29, 2020
@B4nan B4nan merged commit 55ff27d into mikro-orm:dev Apr 29, 2020
@B4nan B4nan mentioned this pull request Apr 29, 2020
B4nan pushed a commit that referenced this pull request Apr 29, 2020
@B4nan B4nan mentioned this pull request Apr 30, 2020
46 tasks
B4nan pushed a commit that referenced this pull request May 3, 2020
B4nan pushed a commit that referenced this pull request May 21, 2020
B4nan pushed a commit that referenced this pull request Jun 1, 2020
B4nan pushed a commit that referenced this pull request Jun 5, 2020
B4nan pushed a commit that referenced this pull request Jun 16, 2020
B4nan pushed a commit that referenced this pull request Aug 2, 2020
B4nan pushed a commit that referenced this pull request Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants