getQuery causing inconsistencies in queryBuilder execution with JsonType and complex query

[Darent98]

Describe the bug

I've identified a bug related to an entity containing a property of type JsonType. This bug occurs specifically when executing a query builder (qb) with a complex where statement after invoking the getQuery() method on the qb object.

Interestingly, the complex query functions correctly when the getQuery() method is not called before execution. Additionally, I've provided a simple query where the bug is not reproducible.

To reproduce the error, you can utilize the provided reproduction case.

A workaround for this issue is to use qb.clone(true).getQuery(). However, it's worth noting that the observed behavior with both simple and complex queries appears inconsistent.

Reproduction

import { Entity, JsonType, MikroORM, PrimaryKey, Property, QBFilterQuery } from '@mikro-orm/sqlite';

@Entity()
class Test {

  @PrimaryKey()
  id!: number;

  @Property({type: JsonType, nullable: true})
  a!: any

  constructor(a: any) {
    this.a = a
  }

}

let orm: MikroORM;

beforeAll(async () => {
  orm = await MikroORM.init({
    dbName: ':memory:',
    entities: [Test],
    debug: ['query', 'query-params'],
    allowGlobalContext: true, // only for testing
  });
  await orm.schema.refreshDatabase();
  orm.em.create(Test, { a: {
    value: 1
  } });
  orm.em.create(Test, { a: {
    complex: {
      bool: true
    }
  } });
  await orm.em.flush();
  orm.em.clear();
});

afterAll(async () => {
  await orm.close(true);
});

test('simple - no getQuery', async () => {
  const query: QBFilterQuery<Test> = {a: {value: 1}}
  const qb = orm.em.qb(Test).andWhere(query)
  const res = await qb.execute() // proper sql query is generated
  expect(res.length).toBe(1) // result as expected
})

test('simple - with getQuery', async () => {
  const query: QBFilterQuery<Test> = {a: {value: 1}}
  const qb = orm.em.qb(Test).andWhere(query)
  qb.getQuery()
  const res = await qb.execute() // proper sql query is generated
  expect(res.length).toBe(1) // result as expected
})

test('complex working', async () => {
  const query = {$and: [{$or: [{a: {value: 1}}, {a: {complex: {bool: true}}}]}]}
  const qb = orm.em.qb(Test).andWhere(query)
  const res = await qb.execute() // proper sql query is generated
  expect(res.length).toBe(2); // result as expected
});

test('complex not working', async () => {
  const query = {$and: [{$or: [{a: {value: 1}}, {a: {complex: {bool: true}}}]}]}
  const qb = orm.em.qb(Test).andWhere(query)
  qb.getQuery()
  const res = await qb.execute() // faulty sql query is generated
  expect(res.length).toBe(2)
});

What driver are you using?

@mikro-orm/sqlite

MikroORM version

6.1.1-dev.3

Node.js version

v20.10.0

Operating system

Linux

Validations

• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Slack.
• The provided reproduction is a minimal reproducible example of the bug.