fix(entity-generator): use Ref wrapper on all lazy properties
#5252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For convenience in the common case, when the identifiedReferences is set to true, lazy relations should also be wrapped by Ref, thus simplifying what onInitialMetadata needs to do. There should be no change when identifiedReferences is set to false. Metadata hooks can selectively opt out of some Ref wrappers by setting Ref to false in onProcessedMetadata, or ensure they never get Ref wrappers regardless of identifiedReferences by only adding lazy flags in onProcessedMetadata. Since the docs are also touched anyway to clarify this behavior, listings about the recently added features are also added.
B4nan
reviewed
Feb 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5252 +/- ##
========================================
Coverage 99.74% 99.74%
========================================
Files 222 222
Lines 16841 16842 +1
Branches 3588 4104 +516
========================================
+ Hits 16798 16799 +1
Misses 43 43 ☔ View full report in Codecov by Sentry. |
B4nan
changed the title
Ref wrapper on all lazy properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For convenience in the common case, when the identifiedReferences is set to true, lazy relations should also be wrapped by Ref,
thus simplifying what onInitialMetadata needs to do.
There should be no change when identifiedReferences is set to false.
Metadata hooks can selectively opt out of some Ref wrappers by setting Ref to false in onProcessedMetadata,
or ensure they never get Ref wrappers regardless of identifiedReferences by only adding lazy flags in onProcessedMetadata.
Since the docs are also touched anyway to clarify this behavior, listings about the recently added features are also added.