fix(entity-generator): optional and hidden properties get type option + string defaults #5264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boenrobot
force-pushed
the
differentButStillTheSameDefaultOptionals
branch
from
ae6e135
to
662fbda
Compare
|
The branch is on top of #5254. I thought I shouldn't amend that other one, because review would be harder... but at the same time, changes are substantial enough, that I can't exactly do them from master without that other one in... |
boenrobot
force-pushed
the
differentButStillTheSameDefaultOptionals
branch
5 times, most recently
from
1282629
to
0b4d9a7
Compare
… + string defaults The "default" option is no longer emitted into the decorator, in favor of it being specified in the property's declaration at the entity class. The "defaultRaw" option is still used in cases where the SQL expression does not unambiguously map to the "default" option's value. The MySQL and MariaDB schema helper translates TINYINT(1) with a values of 0 or 1 to "false" or "true", respectively. This ensures behavior consistent with other drivers. And if this value accidentally finds its way back in a query, it is also OK, as MySQL and MariaDB treat those literals as those number literals. The "optional" option is now added early, in the DatabaseTable stage. This has also unlocked some ManyToMany relations that were previously not detected. Closes #5260
boenrobot
force-pushed
the
differentButStillTheSameDefaultOptionals
branch
from
0b4d9a7
to
037efaf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5264 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 222 222
Lines 16855 16856 +1
Branches 4110 4117 +7
=======================================
+ Hits 16812 16813 +1
Misses 43 43 ☔ View full report in Codecov by Sentry. |
B4nan
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "default" option is no longer emitted into the decorator, in favor of it being specified in the property's declaration at the entity class. The "defaultRaw" option is still used in cases where the SQL expression does not unambiguously map to the "default" option's value.
The MySQL schema helper translates TINYINT(1) with a value of 0 to "false". This ensures behavior consistent with other drivers. And if this value accidentally finds its way back in a query, it is also OK, as MySQL treats this literal as "0".
The "optional" option is now added early, in the DatabaseTable stage. This has also unlocked some ManyToMany relations that were previously not detected.
Closes #5260