Enum Array doesn't work with nativeEnumName

[NeelDigonto]

Describe the bug

Enum Array doesn't work with nativeEnumName

Reproduction

  @Enum({
    items: () => TenantFeatureFlag,
    array: true,
  })
  tenantFeatureFlags: TenantFeatureFlag[];

This creates

"tenantFeatureFlags" text[] not null

  @Enum({
    items: () => TenantFeatureFlag,
    array: true,
    nativeEnumName: 'TenantFeatureFlag',
  })
  tenantFeatureFlags: TenantFeatureFlag[];

But this produces

"tenantFeatureFlags" "TenantFeatureFlag" not null

It's missing the [] after TenantFeatureFlag.

The update query then fails with

DriverException ... '{feat1, feat2}' ... - invalid input value for enum "TenantFeatureFlag": "{feat1,feat2}"

Using Reflect Metadata, and swc with the recommended settings.

{
  "jsc": {
    "parser": {
      "syntax": "typescript",
      "tsx": false,
      "decorators": true,
      "dynamicImport": true
    },
    "transform": {
      "legacyDecorator": true,
      "decoratorMetadata": true
    },
    "target": "esnext",
    "baseUrl": ".",
    "paths": {
      "@/*": ["./src/*"]
    }
  },
  "module": {
    "type": "commonjs"
  },
  "minify": false,
  "sourceMaps": true
}

I can provide more reproduction, if the bug is not obvious.

What driver are you using?

@mikro-orm/postgresql

MikroORM version

6.1.6

Node.js version

20.11.1 LTS

Operating system

Ubuntu 23.04

Validations

• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Slack.
• The provided reproduction is a minimal reproducible example of the bug.

[B4nan]

This might be a bit tricky, it feels like knex does not support native enum arrays at all, haven't found a single issue on their end, and I don't see a way to even set up such a column (only via table. specificType(), which is kinda the same as using raw queries...).

This does not mean there is no way around it, but it complicates things - we will need to implement some things that knex is doing (but better, lol), so we don't use table.enum() at all for native enum arrays.

Edit: turns out its pretty simple change, will finalize it later today

[NeelDigonto]

@B4nan Thank you so much for the quick updates.
I will test them tomorrow.

[NeelDigonto]

@B4nan
I tried it now,

1. With getCreateSchemaSQL() as in your mock, the returned SQL is correct and as expected.
2. With getUpdateSchemaSQL() the enum creation SQL is itself not present, but it is correctly references for ex. as TenantFeatureFlag[].
3. With migration create from Migrator, again enum creation is itself not present in the SQL but referenced correctly.

[B4nan]

I knew it will be more tricky :D

[NeelDigonto]

@B4nan Will test again once it's released.
Again, thank you so much for you time. I never expected any project maintainer to be so active.
You are one heck of a maintainer.

Again, thank you so much for your efforts.

[B4nan]

Btw you can test the dev version already, every commit to master gets published.