fix(postgres): removed erroneous duplicates in FK discovery query #5376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B4nan
approved these changes
Mar 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5376 +/- ##
==========================================
- Coverage 99.70% 99.70% -0.01%
==========================================
Files 222 222
Lines 17047 17045 -2
Branches 4190 3668 -522
==========================================
- Hits 16997 16995 -2
Misses 50 50 ☔ View full report in Codecov by Sentry. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue introduced in v6.1.12 (2dff96b).
The query used to discover foreign keys was returning erroneous duplicate rows. The fixed query removes the duplicates and ensures FK columns are returned in the correct order.
This PR also reverses changes to the SchemaHelper, which are no longer needed.