feat(ts-morph): use .d.ts files for ts-morph discovery
#616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to analyse `.d.ts` files instead of the actual entity source files. Also instead of analysing the whole project based on `tsconfig.json`, we now use the list of paths to actual entities (we know them from the decorators), changing the extension from `.js` to `.d.ts`. BREAKING CHANGE: Removed `discovery.tsConfigPath` option as it is no longer needed, it was used only for `TsMorphMetadataProvider`, when the `entitiesDirsTs` were not explicitly provided. In v4, this is no longer needed, as ts-morph discovery will use `d.ts` files instead, that should be located next to the compiled entities.
B4nan
added a commit
that referenced
this pull request
Aug 2, 2020
This allows to analyse `.d.ts` files instead of the actual entity source files. Also instead of analysing the whole project based on `tsconfig.json`, we now use the list of paths to actual entities (we know them from the decorators), changing the extension from `.js` to `.d.ts`. BREAKING CHANGE: Removed `discovery.tsConfigPath` option as it is no longer needed, it was used only for `TsMorphMetadataProvider`, when the `entitiesDirsTs` were not explicitly provided. In v4, this is no longer needed, as ts-morph discovery will use `d.ts` files instead, that should be located next to the compiled entities.
B4nan
added a commit
that referenced
this pull request
Aug 9, 2020
This allows to analyse `.d.ts` files instead of the actual entity source files. Also instead of analysing the whole project based on `tsconfig.json`, we now use the list of paths to actual entities (we know them from the decorators), changing the extension from `.js` to `.d.ts`. BREAKING CHANGE: Removed `discovery.tsConfigPath` option as it is no longer needed, it was used only for `TsMorphMetadataProvider`, when the `entitiesDirsTs` were not explicitly provided. In v4, this is no longer needed, as ts-morph discovery will use `d.ts` files instead, that should be located next to the compiled entities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to analyse
.d.tsfiles instead of the actual entity source files. Alsoinstead of analysing the whole project based on
tsconfig.json, we now use the listof paths to actual entities (we know them from the decorators), changing the extension
from
.jsto.d.ts.BREAKING CHANGE:
Removed
discovery.tsConfigPathoption as it is no longer needed, it was used onlyfor
TsMorphMetadataProvider, when theentitiesDirsTswere not explicitly provided.In v4, this is no longer needed, as ts-morph discovery will use
d.tsfiles instead,that should be located next to the compiled entities.