feat(core): refactor merging to allow querying by custom type #800
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes internal mechanism of
em.merge()
. Originally it was usingEntityAssigner
insideem.merge()
together withUoW.merge()
, whichwas called twice. Because of this, the custom types were processed multiple
times, and the value passed to conversion method was often already converted.
Now we use only the
Hydrator
for this. As a sideproduct of those changes,we can now query by custom types.
Closes #739