Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only create migrations folder if migrationsList is not used #941

Merged
merged 6 commits into from
Oct 21, 2020
Merged

fix: only create migrations folder if migrationsList is not used #941

merged 6 commits into from
Oct 21, 2020

Conversation

thomaschaaf
Copy link
Contributor

@thomaschaaf thomaschaaf commented Oct 21, 2020 •
edited
Loading

@B4nan
Copy link
Member

B4nan commented Oct 21, 2020

Looking good, lets wait for the CI.

@thomaschaaf
Copy link
Contributor Author

@B4nan I don't think the failing code climate has anything to do with my changes.

@B4nan
Copy link
Member

B4nan commented Oct 21, 2020

Yeah that's fine, some configuration mismatch. Tests are passing and full coverage is remained, that is what is important.

@B4nan B4nan merged commit 1e5c5e8 into mikro-orm:master Oct 21, 2020
@thomaschaaf thomaschaaf deleted the fix/migrations-for-list branch October 21, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B4nan B4nan B4nan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thomaschaaf @B4nan