feat: return value from UseRequestContext callback #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks, can you please add some basic tests to verify it works and ensure we dont break it? |
|
Yes, of course, I will try next week |
TLmaK0
changed the title
B4nan
reviewed
Jul 13, 2021
TLmaK0
force-pushed
the
master
branch
2 times, most recently
from
e960f81
to
e40ee8a
Compare
Langstra
reviewed
Jul 13, 2021
B4nan
approved these changes
Aug 28, 2021
| @@ -29,12 +29,12 @@ class ConfigService implements MikroOrmOptionsFactory { | |||
| @Module({ providers: [ConfigService, myLoggerProvider], exports: [ConfigService] }) | |||
| class ConfigModule { } | |||
|
|
|||
| const getEntityManagerLoop = async (module: TestingModule): Promise<Set<string>> => { | |||
| const getEntityManagerLoop = async (module: TestingModule): Promise<Set<number | string>> => { | |||
There was a problem hiding this comment.
Suggested change
| const getEntityManagerLoop = async (module: TestingModule): Promise<Set<number | string>> => { | |
| const getEntityManagerLoop = async (module: TestingModule): Promise<Set<string>> => { |
| // this function mocks the contextId factory which is called on each request | ||
| // it's looped 5 times and resolves the EntityManager provider 10 times | ||
| // set only allows unique values, it should only return 5 items as it should resolve the same em with the same contextId | ||
|
|
||
| const generatedIds = new Set<string>(); | ||
| const generatedIds = new Set<number | string>(); |
There was a problem hiding this comment.
Suggested change
| const generatedIds = new Set<number | string>(); | |
| const generatedIds = new Set<string>(); |
|
looks like i dont have write access to your fork, so please either rebase this and remove the conflicting changes in |
B4nan
changed the title
|
thanks! |
|
My pleasure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #21