Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable span-tag to accept finc-Solr-Schema (JSON/ldj) as input #2

Open
zazi opened this issue Aug 21, 2017 · 1 comment
Open

enable span-tag to accept finc-Solr-Schema (JSON/ldj) as input #2

zazi opened this issue Aug 21, 2017 · 1 comment
Assignees

Comments

@zazi
Copy link
Contributor

zazi commented Aug 21, 2017

(from my knowledge) currently, span-tag can consume Intermediate Schema (JSON/ldj). However, it might also be useful, if it can eat finc-Solr-Schema (JSON/ldj), because not all data source can be mapped to the Intermediate Schema.

@miku
Copy link
Owner

miku commented Aug 21, 2017

Yes, this is currently a limitation. I started to make the filters a bit more independent in the sift subpackage, which only requires certain small interfaces to be implemented to be able to use filters.

For example, a Go struct (which maps to JSON nicely) that implements SerialNumberer should be able to use an ISSN filter and so on.

What's left to do is to make SOLR schema implement these interfaces and then allow span-tag to map some name to some struct. I hope this will be done shortly.

@miku miku self-assigned this Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants