Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are flaky with sqlite backend #942

Closed
dwf opened this issue Jan 17, 2016 · 5 comments
Closed

Tests are flaky with sqlite backend #942

dwf opened this issue Jan 17, 2016 · 5 comments
Labels

Comments

@dwf
Copy link
Contributor

dwf commented Jan 17, 2016

Both #940 and in-progress #941 have encountered failing tests with the sqlite backend. What's particularly troubling is that they are not failing deterministically, but only sometimes.

@dwf dwf added the bug label Jan 17, 2016
@dwf
Copy link
Contributor Author

dwf commented Jan 17, 2016

I've seen this one fail a number of times, again, only with sqlite.

======================================================================
FAIL: tests.extensions.test_training.FunctionTestCase (test_save_the_best)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/extensions/test_training.py", line 147, in test_save_the_best
    assert main_loop.log[4]['saved_to'] == (dst.name, dst_best.name)
AssertionError

@rizar
Copy link
Contributor

rizar commented Jan 19, 2016

As discussed today, I think we should move SQLiteBackendto Blocks_extras, which first and foremost requires a method of plugging additional backends from Blocks_extras to Blocks.

@dwf
Copy link
Contributor Author

dwf commented Jan 24, 2016

I'm going to say that we should not let the perfect be the enemy of the good, and until we can actually remove the SQLiteBackend (and figure out what is wrong with it) we should silence the failing test for the time being so that the CI status is actually useful again.

@dwf
Copy link
Contributor Author

dwf commented Jan 24, 2016

Superseded by #954, #955.

@dwf dwf closed this as completed Jan 24, 2016
@dwf dwf reopened this Jan 24, 2016
@dwf
Copy link
Contributor Author

dwf commented Jan 24, 2016

I'll let this be closed by #953 when merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants