Merge pull request #965 from rizar/secure_get_dim

Safety check in LookupTable.get_dim
mila-iqia · Feb 1, 2016 · 2131a0c · 2131a0c
2 parents d130424 + be7090f
commit 2131a0c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/blocks/bricks/lookup.py b/blocks/bricks/lookup.py
@@ -69,3 +69,4 @@ def get_dim(self, name):
             return self.dim
         if name == 'indices':
             return 0
+        return super(LookupTable, self).get_dim(name)
diff --git a/tests/bricks/test_lookup.py b/tests/bricks/test_lookup.py
@@ -1,5 +1,5 @@
 import numpy
-from numpy.testing import assert_equal
+from numpy.testing import assert_equal, assert_raises
 
 import theano
 from theano import tensor
@@ -25,3 +25,4 @@ def test_lookup_table():
     # Test get_dim
     assert_equal(lt.get_dim(lt.apply.inputs[0]), 0)
     assert_equal(lt.get_dim(lt.apply.outputs[0]), lt.dim)
+    assert_raises(ValueError, lt.get_dim, 'random_name')