Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CostMatrix requires 2D inputs #1083

Open
dwf opened this issue May 13, 2016 · 1 comment
Open

CostMatrix requires 2D inputs #1083

dwf opened this issue May 13, 2016 · 1 comment
Labels
bug trivial fix

Comments

@dwf
Copy link
Contributor

dwf commented May 13, 2016 •
edited

This should really conditionally sum over axis=1 if it exists. Or maybe not at all, e.g. BinaryCrossEntropy doesn't.

https://github.com/mila-udem/blocks/blob/master/blocks/bricks/cost.py#L27
@dwf dwf changed the title SquaredError requires 2D inputs CostMatrix requires 2D inputs May 13, 2016
@dwf
Copy link
Contributor Author

dwf commented May 13, 2016

Okay, my bad. Rather, It actually does. I still think it ought to be an option to CostMatrix whether to do this summing out, and at least to not complain on 1D inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug trivial fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dwf