Inherit load from SimpleExtension for flexibility #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks fine but what happened to the python2 tests? |
rizar
force-pushed
the
change_load_ancestor
branch
from
e65a35a
to
1ac218b
Compare
|
I fixed the expected exception in the convolution tests, now should work. |
|
Since @dmitriy-serdyuk said it looks find, I am merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inheriting
LoadfromSimpleExtensionhas an advantage that it can be enabled/disabled by callingSimpleExtension.set_conditions(). It should be a super easy PR to review.