Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix route constants in generated router switch statements with router class #9

Closed
kuhnroyal opened this issue Dec 20, 2019 · 2 comments
Closed

Prefix route constants in generated router switch statements with router class #9

kuhnroyal opened this issue Dec 20, 2019 · 2 comments

Comments

@kuhnroyal
Copy link
Contributor

I just had a conflict with a route named settings. This conflicts in the generated router class with RouteSettings settings.

This can simply be fixed by always prepending the router class to all constant expressions:

case settings: // conflict
// to
case AppRouter.settings:
@Milad-Akarie
Copy link
Owner

I'll take a look at it.

@Milad-Akarie
Copy link
Owner

done in version 0.2.1.

@Tejasvp25 Tejasvp25 mentioned this issue Aug 1, 2020
Closed
@himanshu64 himanshu64 mentioned this issue Aug 8, 2020
Closed
@prantto prantto mentioned this issue May 28, 2021
Closed
@BC89 BC89 mentioned this issue Jul 12, 2022
Closed
@olegys olegys mentioned this issue Sep 29, 2022
Open
@Kuodster Kuodster mentioned this issue Apr 6, 2023
Closed
@SifAa SifAa mentioned this issue Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kuhnroyal @Milad-Akarie