Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier navigation of detected loads #11

Closed
SteveManaclaw opened this issue Nov 30, 2021 · 11 comments
Closed

Easier navigation of detected loads #11

SteveManaclaw opened this issue Nov 30, 2021 · 11 comments
Labels
enhancement New feature or request

Comments

@SteveManaclaw
Copy link

Hey there. Love the new update and the new features it brings, but I have one suggestion that in my experience would significantly improve the program's usability at least for games that have a large amount of loading screens (100+ for example).

I like using the "Snap to detected loads" toggle to quickly skim through a video and see if there's any false-positive frames at the beginnings or ends of detected loads, but I find this feature a bit difficult to use in its current iteration. At the moment it seems the only way to tab through each load in this way is with the mouse on the video scrubber which is bit difficult/straining when you've got to scrub through a bunch of loads and don't want to skip over any for a long run.

I'd love if there was a way to do this with the keyboard or just a button in the UI (maybe next to the "Snap to detected loads" checkbox?) that one could use to move forward/backwards in a way that mimics the scrubber's functionality with this setting checked. I envision something similar to how the forward/backward frame buttons already work, but specifically it would move forward/backward between each load.

At least for my use case this would help a bunch since using the mouse is difficult and clicking on each load individually with the "Go" buttons would be too tedious when just looking to skim through. Thanks.

@milankarman
Copy link
Owner

I like this idea. I'd probably want to make it so you could simultaneously see the frame before the start of a load screen and the frame after the end of a load screen. Definitely going to add this but I won't make any promises on how quickly I'll get it done.

@Avasam
Copy link
Contributor

Avasam commented Feb 3, 2022

I like this idea. I'd probably want to make it so you could simultaneously see the frame before the start of a load screen and the frame after the end of a load screen. Definitely going to add this but I won't make any promises on how quickly I'll get it done.

Hi. I came from your Youtube demo (after seeing your Hobbit WR history documentary). And suggested the same thing there.

Being able to confirm load start and end at a glance by showing the frame before and after would increase productivity and usability by a lot.

It could even be a thumbnail preview (1 frame before, 1 frame mid-load, 1 frame after) in the right-side column. Allowing instantaneous visual confirmation without having to click around.

@milankarman
Copy link
Owner

milankarman commented Feb 3, 2022

Thanks for the suggestion. I had something similar in mind where you open a separate window showing the load frame and the frame before/after and are able to make quick edits to each frame if needed. Just showing them in another column might be a lot easier though so I'll consider it.

Unfortunately I just haven't really had motivation to work on this so still no promises on when I'll get to it.

@milankarman milankarman added the enhancement New feature or request label Feb 5, 2022
@milankarman milankarman added this to To do in Unload 1.3.0 Feb 5, 2022
@Avasam
Copy link
Contributor

Avasam commented Feb 7, 2022

Rough draft just for discussion, I was thinking something like this. Where we could see the previous and next frames out of load so the visual validation becomes extremely quick:

  • When feasable for a game, check if the total number of loads match what you expect
  • Then...
Quickly scroll through the load frames Or probably even better, this
image image

I think it would go a long way in speeding up this step which is important, but currently requires a lot of tedious clicking around.

@milankarman
Copy link
Owner

A list like that seems like a great idea but I think I'd like to keep it separate from the main load list. I'm thinking of adding a button that will open up a window dedicated to checking and fixing the loads which would be pretty much like this but in a dedicated spot.

@milankarman milankarman moved this from To do to In progress in Unload 1.3.0 Feb 17, 2022
@milankarman
Copy link
Owner

This is the load checking window layout I think I'll be going with. Feedback and questions are welcome.
LoadCheckingDesign

@Avasam
Copy link
Contributor

Avasam commented Feb 17, 2022

This is the load checking window layout I think I'll be going with. Feedback and questions are welcome. !

Seems everything is there: previous, first, last, next, and a way to scrub quickly through them all. And it's all pretty clearly indicated.

Since it's not shown in your preview, would it be full images or cropped to the load?

I liked the idea of being able to view multiple / scroll through at a glance. But this works as well.

@milankarman
Copy link
Owner

I was going full frames, no cropping. But I could make cropped preview a toggle if there's demand (let me know).
The reason I ended up going with a full view over a list was because for some console runs with interlacing I want a big view to easily tell when the frames blend.
I also hope this will actually work faster than a list because your eyes don't have to move along with scrolling pictures. Instead you're just able to focus on the same spot while the slider acts similar to a scroll.

@SteveManaclaw
Copy link
Author

This looks great to me. I don't immediately see anything obvious missing. Should improve usability by quite a lot. Really like the idea of also showing the frames before and after each load- I wouldn't have even thought of that!

I do agree that having the full frame showing is probably a better default than a cropped view.

@Avasam
Copy link
Contributor

Avasam commented Feb 17, 2022

Those 4 frame previews are big enough it makes sense to have the full frame. I am sure some games will make it more obvious whether it's a load by looking at the whole image, and it's not so small you loose on important details.

Some might have a different preference, but I don't think an option is necessary unless there's a high demand for it.

@milankarman milankarman moved this from In progress to Done in Unload 1.3.0 Feb 19, 2022
@milankarman
Copy link
Owner

Implemented in 1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Unload 1.3.0
Ready for release
Development

No branches or pull requests

3 participants