Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Save preferred settings #17

Closed
Avasam opened this issue Feb 6, 2022 · 5 comments
Closed

[Feature request] Save preferred settings #17

Avasam opened this issue Feb 6, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@Avasam
Copy link
Contributor

Avasam commented Feb 6, 2022

Just like in #12 , there are some settings I believe could benefit from being saved across sessions of Unload.

  • Minimum Similarity
  • Minimum Frames
  • Concurrent tasks
  • Fast forward step size
  • Snap to detected loads
@milankarman
Copy link
Owner

Seems like a good idea, especially if more features are added in the future. Though I think I want to omit minimum similarity and minimum frames from saved settings, as those settings should be changed for different videos and runs - so getting too comfortable with saved settings there might cause user error. Though maybe it would be a good idea to leave an option for them in a config file anyway for advanced users.

@milankarman milankarman moved this from To do to In progress in Unload 1.3.0 Feb 7, 2022
@milankarman milankarman moved this from In progress to To do in Unload 1.3.0 Feb 7, 2022
@Avasam
Copy link
Contributor Author

Avasam commented Feb 7, 2022

I'll vouch for Minimum Similarity since, for me, 0.95 is 0.0001(~ish, I don't remember exactly) short using pHash for one of the games I verify and tested with. So I set it to 0.96. If it really has to be an advanced user default value, then so be it. Otherwise I think it will be annoying to forget to update that value and see I have 1 load too many.

@milankarman
Copy link
Owner

How does a checkbox for remembering load detection settings sound? That way it's at least a conscious decision.

@Avasam
Copy link
Contributor Author

Avasam commented Feb 7, 2022

How does a checkbox for remembering load detection settings sound? That way it's at least a conscious decision.

If you think it fits well your UI, that's fine by me.

@milankarman milankarman moved this from To do to In progress in Unload 1.3.0 Feb 20, 2022
@milankarman milankarman moved this from In progress to Ready for release in Unload 1.3.0 Feb 20, 2022
@milankarman
Copy link
Owner

Implemented in version 1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Unload 1.3.0
Ready for release
Development

No branches or pull requests

2 participants