Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable transform warning #144

Closed
cguinnup opened this issue Jan 3, 2017 · 5 comments
Closed

Option to disable transform warning #144

cguinnup opened this issue Jan 3, 2017 · 5 comments
Assignees

Comments

@cguinnup
Copy link

cguinnup commented Jan 3, 2017

Hello again! :)

I'm using livereactload to bundle the output of compiled Typescript. Since the Typescript compiler has watch mode and JSX transformation, I find the babel React transform unnecessary. Similarly, someone may wish to manually transform the JSX before sending their Javascript to Browserify. For cases like this, I propose a new option:

--no-transform

Will skip the check for Babel React transform & display no warning.
API: opts.transform - When set to false, is equivalent to the above switch.

I can make the simple changes.

@milankinen
Copy link
Owner

milankinen commented Jan 3, 2017

Hi!

Good suggestion, I'd gladly accept the PR. 😄 However, could we use some other option name because "transform" is a bit ambiguous (Browserify transform vs Babel transform). How about e.g. --no-babel?

@cguinnup
Copy link
Author

cguinnup commented Jan 3, 2017

I hear you. --no-babel works!

@milankinen
Copy link
Owner

Included in 3.2.0!

@EugeneZ
Copy link
Contributor

EugeneZ commented Mar 17, 2017

Without the babel transform, your components are not being proxied and hence state is lost. Are you manually proxying them somehow? Or are you simply ok with getting simple non-React-specific HMR?

@cguinnup
Copy link
Author

I've been keeping state with React-Redux and reacting to the module.onReload event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants