Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrites JS to DOM multiple times #53

Closed
zrosenbauer opened this issue Aug 20, 2015 · 4 comments
Closed

Rewrites JS to DOM multiple times #53

zrosenbauer opened this issue Aug 20, 2015 · 4 comments
Labels

Comments

@zrosenbauer
Copy link

It's way past my bed time at this point....so maybe some sleep would help me resolve this but I seem to be having issues with Babelify + BrowserSync + React-Router + LiveReactLoad. (Thanks BTW as this really lets us stick with Browserify)

It works fine on the first, but not on the second and so on same as: #43

I am new to LiveReactLoad....and I'm pretty sure it's not a React-Router issue, any help would be VERY appreciated. BTW if I find some time I might try to help with that magic bullet for React-router if I can :)

@milankinen milankinen added the bug label Aug 25, 2015
@milankinen
Copy link
Owner

Yeah. I'm going to rewrite the live reloading logic by using react-proxy and I'm going to steal some ideas from react-patch-server and browserify-hrm

That should be able to handle this issue correctly. :)

@milankinen
Copy link
Owner

Could you check if this problem is still present in the brand new 2.0.0-alpha2 version? https://github.com/milankinen/livereactload/tree/2.x.x

@zrosenbauer
Copy link
Author

@milankinen When I get a chance I'll pull it down and take a look. We switched to webpack though as we had to roll. Keep it up though as I am still a fan of browserify for my smaller projects!

@milankinen
Copy link
Owner

Can I close this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants