Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How's the performance of this implementation #39

Closed
eglxiang opened this issue Dec 6, 2018 · 4 comments
Closed

How's the performance of this implementation #39

eglxiang opened this issue Dec 6, 2018 · 4 comments

Comments

@eglxiang
Copy link

eglxiang commented Dec 6, 2018

No description provided.

@milesial
Copy link
Owner

milesial commented Dec 6, 2018

The network implementation relies on Pytorch, so its performance is on par with the framework's. There shouldn't be anything special if you use the last version of pytorch. If you use bilinear=True for the upsampling, things are faster and need less memory.

About the data loading and overall pipeline, it's Python so you get what you expect.

@xiaoxingzeng
Copy link

This implementation is very different from the origin U-Net, I think its depend on your task.

@milesial
Copy link
Owner

milesial commented Dec 7, 2018

@xiaoxingzeng Can you tell me what's different from the original architecture ? I think my implementation matches the Fig. 1 from https://arxiv.org/pdf/1505.04597.pdf

@xiaoxingzeng
Copy link

@xiaoxingzeng Can you tell me what's different from the original architecture ? I think my implementation matches the Fig. 1 from https://arxiv.org/pdf/1505.04597.pdf

Hi milesial, I check the paper and your code.
Sorry,it's my mistake, I reference the paper not the origin paper you referenced. Your reimplementation is correct.

@milesial milesial closed this as completed Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants