Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unions compiling down to invalid values #31

Closed
milesj opened this issue Jan 27, 2020 · 0 comments
Closed

Unions compiling down to invalid values #31

milesj opened this issue Jan 27, 2020 · 0 comments

Comments

@milesj
Copy link
Owner

milesj commented Jan 27, 2020

Ran into this myself today. This prop type scrollToGroup: _pt.oneOfType([_pt.oneOf([''])]), was crashing our builds.

Source: https://github.com/milesj/interweave/blob/master/packages/emoji-picker/src/EmojiList.tsx#L25

Looks like I need to also filter out empty strings? Man, dealing with unknown refs is getting gross.
@milesj milesj closed this as completed Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@milesj