Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alias "tada" to "hooray" #52

Closed
tredondo opened this issue Apr 22, 2020 · 2 comments
Closed

Alias "tada" to "hooray" #52

tredondo opened this issue Apr 22, 2020 · 2 comments

Comments

@tredondo
Copy link

tredondo commented Apr 22, 2020 •
edited

(and maybe "confetti" as well?)

image
@tredondo tredondo changed the title Alias "tadat" to "hooray" Alias "tada" to "hooray" Apr 22, 2020
@milesj milesj mentioned this issue Aug 11, 2020
Merged
6 tasks
@nolanlawson
Copy link

Looks like both :tada: and :hooray: are supported now in v6 depending on the shortcodes source (GitHub versus Emojibase):

emojibase/packages/data/en/shortcodes/github.raw.json

Line 1637 in 5bb6aae

"1F389": "tada",

emojibase/packages/data/en/shortcodes/emojibase.raw.json

Line 3222 in 6e2faba

"hooray"

Seems this issue can be closed?

@milesj
Copy link
Owner

milesj commented Sep 13, 2020

It can! Thanks.

@milesj milesj closed this as completed Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@milesj @nolanlawson @tredondo