Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including src/ into the bundled package #91

Closed
ocavue opened this issue Feb 18, 2021 · 1 comment
Closed

Including src/ into the bundled package #91

ocavue opened this issue Feb 18, 2021 · 1 comment

Comments

@ocavue
Copy link

ocavue commented Feb 18, 2021

The npm package emojibase includes index.js.map but doesn't include src/*.ts. This will make a bundler unable to find the source code according to the map files. I propose that we include src/ inside the npm package or remove *.map from the npm package.

$ yarn run parcel index.html
Server running at http://localhost:1234
⚠️  Could not load source file "../src/appendSkinToneIndex.ts" in source map of "node_modules/emojibase/umd/index.js".
⚠️  Could not load source file "../src/fetchFromCDN.ts" in source map of "node_modules/emojibase/umd/index.js".
⚠️  Could not load source file "../src/constants.ts" in source map of "node_modules/emojibase/umd/index.js".
⚠️  Could not load source file "../src/fetchShortcodes.ts" in source map of "node_modules/emojibase/umd/index.js".
⚠️  Could not load source file "../src/joinShortcodesToEmoji.ts" in source map of "node_modules/emojibase/umd/index.js".
⚠️  Could not load source file "../src/flattenEmojiData.ts" in source map of "node_modules/emojibase/umd/index.js".
⚠️  Could not load source file "../src/joinShortcodes.ts" in source map of "node_modules/emojibase/umd/index.js".
⚠️  Could not load source file "../src/fetchEmojis.ts" in source map of "node_modules/emojibase/umd/index.js".
⚠️  Could not load source file "../src/fetchMetadata.ts" in source map of "node_modules/emojibase/umd/index.js".
⚠️  Could not load source file "../src/fromCodepointToUnicode.ts" in source map of "node_modules/emojibase/umd/index.js".
⚠️  Could not load source file "../src/fromHexcodeToCodepoint.ts" in source map of "node_modules/emojibase/umd/index.js".
⚠️  Could not load source file "../src/fromUnicodeToHexcode.ts" in source map of "node_modules/emojibase/umd/index.js".
⚠️  Could not load source file "../src/generateEmoticonPermutations.ts" in source map of "node_modules/emojibase/umd/index.js".
⚠️  Could not load source file "../src/stripHexcode.ts" in source map of "node_modules/emojibase/umd/index.js".
✨  Built in 35.55s.
@milesj
Copy link
Owner

milesj commented Mar 8, 2021

This should be fixed now. Thanks.

@milesj milesj closed this as completed Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants