Skip to content
This repository has been archived by the owner on Jan 29, 2021. It is now read-only.

s3 transporter auto-deleting #17

Closed
ns3777k opened this issue Jan 19, 2015 · 3 comments
Closed

s3 transporter auto-deleting #17

ns3777k opened this issue Jan 19, 2015 · 3 comments

Comments

@ns3777k
Copy link
Contributor

ns3777k commented Jan 19, 2015

Hey! First off thank you for sharing transit :-)

As I can see, in Transit/Transporter/Aws/S3Transporter.php:166, file is always being deleted after successful upload to s3.
Maybe it'd be better to have this behavior as an option?

For example, I wanna upload the same file to s3 and rackspace (redundancy in case s3 is unavailable).
But I don't like the idea to extend this class over a simple option.

What do you think?

@milesj
Copy link
Owner

milesj commented Jan 19, 2015

I don't have anything against it, just that Transit would have to be rewritten to support multiple transporters, as it currently only supports 1 at a time.

@ns3777k
Copy link
Contributor Author

ns3777k commented Jun 13, 2015

been a long time. totally forgot to send a PR :-)
#18

@milesj
Copy link
Owner

milesj commented Jun 13, 2015

Totally forgot about this as well, hah.

@milesj milesj closed this as completed Jun 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants